[U-Boot] [PATCH v2 1/2] ftpmu010: support faraday ftpmu010 driver

Wolfgang Denk wd at denx.de
Wed Feb 16 11:52:04 CET 2011


Dear Macpaul Lin,

In message <AANLkTin8iSrcnAQ8hgNjdTgOa9uLeiCm7murDjz2z_JU at mail.gmail.com> you wrote:
> 
> > If I remember correctly, this patch was not applied
> > because Wolfgang does not like the include "../../../..".
> 
> Yes.
> However, I also found there exists similar include format in other SoC.
> Even you put drivers for all common IP still have the same problem.

Bad examples is not an excuse for adding more bad code. Bad code may
slip through a review, and sometimes it takes a while until we
understand what is god or what is bad.

But when we notice it, we reject it.



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Space is big. You just won't believe how vastly, hugely, mind-
bogglingly big it is. I mean, you may think it's a long way down the
road to the drug store, but that's just peanuts to space.
                              -- The Hitchhiker's Guide to the Galaxy


More information about the U-Boot mailing list