[U-Boot] [PATCH 2/7] mpc8xxx: DDR2/3: Use human-readable SPD DIMM-type constants

[Moffett, Kyle D]

On Feb 21, 2011, at 16:03, Wolfgang Denk wrote:
> In message <1298311199-18775-3-git-send-email-Kyle.D.Moffett at boeing.com> you wrote:
>> Use #define constants to enhance readability of DDR2/3 SPD parsing code.
>> Also add the DDR2 type for an SO-RDIMM module to the switch statement.
>> 
>> Signed-off-by: Kyle Moffett <Kyle.D.Moffett at boeing.com>
>> ---
>> arch/powerpc/cpu/mpc8xxx/ddr/ddr2_dimm_params.c |   34 +++++++++++++++------
>> arch/powerpc/cpu/mpc8xxx/ddr/ddr3_dimm_params.c |   37 ++++++++++-------------
>> common/ddr_spd.c                                |    2 +-
>> include/ddr_spd.h                               |   28 ++++++++++++-----
>> 4 files changed, 60 insertions(+), 41 deletions(-)
> ...
>> +	case DDR3_SPD_MODULETYPE_UDIMM:
>> +	case DDR3_SPD_MODULETYPE_SO_DIMM:
>> +	case DDR3_SPD_MODULETYPE_MICRO_DIMM:
>> +	case DDR3_SPD_MODULETYPE_MINI_UDIMM:
>> +		/* Unbuffered DIMMs */
>> +		pdimm->registered_dimm = 0;
>> +		pdimm->mirrored_dimm = spd->mod_section.unbuffered.addr_mapping & 0x1;
>> 		break;
> 
> Line too long.  Please fix globally.

Ok, will fix.  Although, this one is only 87 characters and some of the other lines already in that file are 93 characters long.

Cheers,
Kyle Moffett
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 6686 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110221/198ef835/attachment.bin