[U-Boot] [PATCH] S3C64XX: timer: replace bss variable by gd

Reinhard Meyer u-boot at emk-elektronik.de
Thu Jan 6 09:53:10 CET 2011


Dear concerned,
>>>>>> Use the global data instead of bss variable, replace as follow.
>>>>>> timer_load_val ->     timer_rate_hz
>>>>>> timestamp ->     timer_reset_value

I am not too happy about this "misuse" of gd->variables making them
"misnomers" and the code harder to read.

timer_rate_hz is supposed to hold the rate at which the high
speed timer increments.

timer_reset_value supposedly holds the high speed timer's value when
timer_reset() is called.

There was a discussion started about this a while ago, but came to no
conclusion...

Best Regards,
Reinhard


More information about the U-Boot mailing list