[U-Boot] [PATCH 2/2 v2] hwmon: do not init sensors on startup

Wolfgang Denk wd at denx.de
Sun Jan 9 17:49:30 CET 2011


Dear Heiko Schocher,

In message <1292232401-26523-1-git-send-email-hs at denx.de> you wrote:
> The U-Boot Design Principles[1] clearly say:
> 
>   Initialize devices only when they are needed within U-Boot, i.e. don't
>   initialize the Ethernet interface(s) unless U-Boot performs a download
>   over Ethernet; don't initialize any IDE or USB devices unless U-Boot
>   actually tries to load files from these, etc. (and don't forget to
>   shut down these devices after using them - otherwise nasty things may
>   happen when you try to boot your OS).
> 
> So, do not initialize and read the sensors on startup.
> 
> Signed-off-by: Heiko Schocher <hs at denx.de>
> cc: Wolfgang Denk <wd at denx.de>
> 
> ---
> - changes since v1
>   add comments from Wolfgang Denk
>   use BUILD_BUG_ON to create a compileerror if there are
>   defined more than 32 sensors.

Please resubmit with the BUILD_BUG_ON patch.  Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I paid too much for it, but its worth it.


More information about the U-Boot mailing list