[U-Boot] [PATCH] update VCMA9 port

Wolfgang Denk wd at denx.de
Sun Jan 9 22:24:35 CET 2011


Dear =?UTF-8?q?David=20M=C3=BCller?=,

In message <1292926154-19802-1-git-send-email-d.mueller at elsoft.ch> you wrote:
> 
> This patch brings the VCMA9 port in sync with the latest U-Boot
> version by doing the following:
>  - do the necessary adjustments to support the ARM relocation feature
>  - use the CFI flash driver (and removing the old one)
>  - various cleanups and coding style fixes
...
> diff --git a/board/mpl/vcma9/config.mk b/board/mpl/vcma9/config.mk
> index e345913..fef5308 100644
> --- a/board/mpl/vcma9/config.mk
> +++ b/board/mpl/vcma9/config.mk
...
> -#CONFIG_SYS_TEXT_BASE = 0x30F80000
> -CONFIG_SYS_TEXT_BASE = 0x33F80000
> +CONFIG_SYS_TEXT_BASE = 0x0

Please move this line into your board config file, and drop the
config.mk file.

> diff --git a/board/mpl/vcma9/lowlevel_init.S b/board/mpl/vcma9/lowlevel_init.S
> index 062e868..cb1518b 100644
> --- a/board/mpl/vcma9/lowlevel_init.S
> +++ b/board/mpl/vcma9/lowlevel_init.S
> @@ -4,9 +4,9 @@
>   * Copyright (C) 1999 2000 2001 Erik Mouw (J.A.K.Mouw at its.tudelft.nl) and
>   *                     Jan-Derk Bakker (J.D.Bakker at its.tudelft.nl)
>   *
> - * Modified for the Samsung SMDK2410 by
> - * (C) Copyright 2002

I understand this file was created using copy & paste; why do you
think it is legal to remove the original copyright notice?

> + * Modified for MPL VCMA9 by
>   * David Mueller, ELSOFT AG, <d.mueller at elsoft.ch>

We don't need this here. This information is present in the commit
logs.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You Don't Have To Be 'Damned' To Work Here, But It Helps!!!
                                             - Terry Pratchett, _Eric_


More information about the U-Boot mailing list