[U-Boot] [PATCH] asm-offsets: generate bd_t size

Wolfgang Denk wd at denx.de
Mon Jan 10 11:46:52 CET 2011


Dear Michal Simek,

In message <4D2ABA41.7030805 at monstr.eu> you wrote:
> 
> I am little bit confused.
> 1. Mike's patch has broken coding style in his patch ("space"+"space"15)

Indeed. Sorry for missing this. The existing code had the same issue.
If you want, then please submit a patch to clean this up for the whole
file.

> 2. I sent that patch 3 days before Mike. (It is the longer story)
> http://lists.denx.de/pipermail/u-boot/2010-December/084095.html
> 
> I like that the patch is in mainline tree because I need it for 
> Microblaze but I don't quite understand that you beat me about coding 
> style and then you apply patch which has broken coding style.
> 
> I don't care if that patch is Mike's or mine I would like to be sure 
> what are that acceptance rules.
> 
> Can you please tell me how this can happen?

Usually I try to process incoming patches sequentially, but this is
not always possible; even if I follow all mail threads this is
unreliable as many people submit new versions of their patches without
proper linking back to the existing threads. So even when trying to
work mostly sequentially, I will frequently jump forward and backward
in time.

In cases like this (different patches for the same thing, submitted
independently by separate people using different Subjects) it is
pretty much pure chance which of the submitted patches gets picked up.
For me the only important thing is that no patches get dropped
unintentionally.


If I remember correctly Mike's patch was part of my todo list in
patchwork, which was what I processed first, completely independent of
submission date.  I don't remember if I moved the patch there myself,
or if somebody else (Mike?) bestowed it upon me.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Nothing ever becomes real until it is experienced.       - John Keats


More information about the U-Boot mailing list