[U-Boot] [RFC] Make sure the chip reset and init right

[Wolfgang Denk]

Dear Yanjun Yang,

In message <AANLkTimOs07p88QYRpWL5wzD+eiVreBiGRqt2Q8DTgr2 at mail.gmail.com> you wrote:
> It seems that the chip can only be reset into a known
> state by using attribute space. The smc_reset and
> smc_enable function also need more lines to make the
> chip work.
> 
> Signed-off-by: YanJun Yang <yangyj.ee at gmail.com>
> ---
>  drivers/net/lan91c96.c |   26 ++++++++++++++++++++++----
>  1 files changed, 22 insertions(+), 4 deletions(-)

Your patch is white space corrupted again; we cannot apply it for
testing.  Please fix.

> +       SMC_outw(dev, LAN91C96_CTR_TE_ENABLE | LAN91C96_CTR_BIT_8,
> LAN91C96_CONTROL);

YOur patch is also line-wrapped.

> +       udelay( 750 );
...
> +       udelay( 750 );
> +       attaddr[LAN91C96_ECOR] &= ~LAN91C96_ECOR_SRESET;
> +       udelay( 750 );
> +       attaddr[LAN91C96_ECOR] |= LAN91C96_ECOR_ENABLE;
> +       udelay( 750 );
> 
> +       /* force 16-bit mode */
> +       attaddr[LAN91C96_ECSR] &= ~LAN91C96_ECSR_IOIS8;
> +       udelay( 750 );

Please omit these bogus spaces arount the function arguments.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"If God had wanted us to use the metric system, Jesus would have  had
10 apostles."