[U-Boot] [PATCH 15/28] Blackfin: fix bd_t handling

Wolfgang Denk wd at denx.de
Mon Jan 10 23:28:23 CET 2011


Dear Mike Frysinger,

In message <201012271142.17334.vapier at gentoo.org> you wrote:
>
> it isnt a problem to have the parens, and it keeps things sane if someone does 
> something like:
> #define CONFIG_SYS_BD_INFO_ADDR   SOME_DEFINE + 0x1000

This would be a violation of basic rules of defensive coding.

Please drop these parens.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I'm a programmer: I don't buy software, I write it.
                                                  -- Tom Christiansen


More information about the U-Boot mailing list