[U-Boot] [PATCH V3 1/5] mv: seperate kirkwood and armada from common setting

Wolfgang Denk wd at denx.de
Tue Jan 11 10:48:27 CET 2011


Dear Lei Wen,

In message <1294730744-29211-2-git-send-email-leiwen at marvell.com> you wrote:
> Since there are lots of difference between kirkwood and armada series,
> it is better to seperate them but still keep the most common file
> shared by all marvell platform in the mv-common configure file.
> 
> This patch move the kirkwood only driver definitoin in mv-common to
> the <soc_name>/config.h.
> 
> This patch is tested with compilation for armada100 and guruplug.
> 
> Signed-off-by: Lei Wen <leiwen at marvell.com>
> ---
>  arch/arm/include/asm/arch-armada100/config.h |   50 +++++++++
>  arch/arm/include/asm/arch-kirkwood/config.h  |  145 +++++++++++++++++++++++++
>  include/configs/aspenite.h                   |    1 +
>  include/configs/mv-common.h                  |  147 ++++----------------------
>  4 files changed, 217 insertions(+), 126 deletions(-)
>  create mode 100644 arch/arm/include/asm/arch-armada100/config.h
>  create mode 100644 arch/arm/include/asm/arch-kirkwood/config.h

NAK for the whole patch series.

I'm not going to review that. Please stick to the rules.
When submitting a new version of the patch you are supposed to descibe
what has been changed. For details please see
http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
While money can't buy happiness, it certainly lets  you  choose  your
own form of misery.


More information about the U-Boot mailing list