[U-Boot] [PATCH][v3] PBL: add support for boot from SPI flash.

[Xie Shaohui-B21989]

>> ---
>> Use CONFIG_RAMBOOT_PBL instead of CONFIG_PBL_BOOT_INDIRECT according to
>Kumar's comment.
>
>CONFIG_RAMBOOT_PBL needs to be documented in the README!
[Xie Shaohui] OK, I'll submit a patch of README.

>
>
>>  	/* TLB 1 */
>>  	/* *I*** - Covers boot page */
>> +#if defined(CONFIG_SYS_RAMBOOT) && defined(CONFIG_SYS_INIT_L3_ADDR)
>> +	/* *I*G - L3SRAM. When L3 is used as 1M SRAM, the address of the
>> +	 * SRAM is at 0xfff00000, it covered the 0xfffff000.
>> +	 * */
>
>Incorrect multiline comment style.  Please fix globally.
[Xie Shaohui] OK.

>
>> --- a/include/configs/corenet_ds.h
>> +++ b/include/configs/corenet_ds.h
>> @@ -28,6 +28,10 @@
>>
>>  #include "../board/freescale/common/ics307_clk.h"
>>
>> +#ifdef CONFIG_RAMBOOT_PBL
>> +#define CONFIG_RAMBOOT_TEXT_BASE        0xfff80000
>> +#endif
>
>Why is this needed? You already set SYS_TEXT_BASE to that value.
[Xie Shaohui] You are right; this is not needed after boards.cfg is used.

>
>> @@ -62,11 +66,17 @@
>>  #ifdef CONFIG_SYS_NO_FLASH
>>  #define CONFIG_ENV_IS_NOWHERE
>>  #else
>> -#define CONFIG_ENV_IS_IN_FLASH
>
>Why remove the CONFIG_ENV_IS_IN_FLASH here, but leave the
>CONFIG_ENV_IS_NOWHERE above?
>
>>  #define CONFIG_FLASH_CFI_DRIVER
>>  #define CONFIG_SYS_FLASH_CFI
>>  #endif
>>
>> +#if defined(CONFIG_RAMBOOT_PBL)
>> +	#define CONFIG_ENV_IS_NOWHERE	1	/* Store ENV in memory only */
>> +#else
>> +	#define CONFIG_ENV_IS_IN_FLASH
>> +	#define CONFIG_ENV_ADDR		(CONFIG_SYS_MONITOR_BASE -
>CONFIG_ENV_SECT_SIZE)
>> +#endif
>
>See previous comment. This should be cleaned up. For example, move this
>block up, and set CONFIG_SYS_NO_FLASH instead.
[Xie Shaohui] OK, I'll clean up these codes.

>
>> +#define CONFIG_SYS_L3_SIZE		(1024 << 10)
>> +#define CONFIG_SYS_INIT_L3_END (CONFIG_SYS_INIT_L3_ADDR +
>> +CONFIG_SYS_L3_SIZE)
>> +
>> +
>> +/*
>
>Drop one of the blank lines, please.
[Xie Shaohui] OK. Thanks.


Best Regards, 
Shaohui Xie