[U-Boot] [PATCH v4] ARM: Avoid compiler optimization for readb, writeb and friends.

Alexander Holler holler at ahsoftware.de
Wed Jan 12 17:49:44 CET 2011


Am 12.01.2011 17:40, schrieb Wolfgang Denk:
> Dear Alexander Holler,
>
> In message<4D2DCB18.20409 at ahsoftware.de>  you wrote:
>> Am 09.01.2011 23:19, schrieb Wolfgang Denk:
>>
>>> gcc 4.5.1 seems to ignore (at least some) volatile definitions,
>>> avoid that as done in the kernel.
>>
>> Have had a look at the asm generated by gcc 4.5.1, looks good.
>>
>> The wrong optimization in arch/arm/cpu/armv7/omap3/clock.c is gone and
>> the writeb in drivers/mtd/nand/omap_gpmc.c doesn't have the problem as
>> the v1-patch.
>
> Thanks - but please send a formal Acked-by: and/or Tested-by: .

Oh, as I'm still listed as the author, I thought that isn't necessary.

I don't know if I should paste the whole patch (this is my first ack ;) 
), but here are both:

Acked-by: Alexander Holler <holler at ahsoftware.de>
Tested-by: Alexander Holler <holler at ahsoftware.de>

Regards,

Alexander


More information about the U-Boot mailing list