[U-Boot] [V2 patch 4/4] SMDK6400: Fix SMDK6400 SDRAM init

Sergei Shtylyov sshtylyov at mvista.com
Thu Jan 13 12:04:36 CET 2011


Hello.

On 12-01-2011 17:52, seedshope wrote:

>>> Since SDRAM init function have already change, So the SDRAM
>>> initial function must be change.

>>> Signed-off-by: seedshope<bocui107 at gmail.com>

>>> diff --git a/board/samsung/smdk6400/smdk6400.c
>>> b/board/samsung/smdk6400/smdk6400.c
>>> index 35aa40b..52b44a8 100644
>>> --- a/board/samsung/smdk6400/smdk6400.c
>>> +++ b/board/samsung/smdk6400/smdk6400.c
>>> @@ -78,10 +78,18 @@ int board_init(void)
>>> return 0;
>>> }
>>>
>>> -int dram_init(void)
>>> +void dram_init_banksize(void)
>>> {
>>> + DECLARE_GLOBAL_DATA_PTR;
>>> +
>>> gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
>>> gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
>>> +}
>>> +
>>> +int dram_init(void)
>>> +{
>>> + gd->ram_size = get_ram_size((volatile long *)CONFIG_SYS_SDRAM_BASE,
>>> + CONFIG_MAX_RAM_BANK_SIZE);

>> Please indent that line more to the right, preferrebly start it under
>> '(volatile long *)'.

> ok, But I don't know how number tab indent is appropriate. May be the effect
> as following?
> gd->ram_size = get_ram_size((volatile long *)CONFIG_SYS_SDRAM_BASE,
> CONFIG_MAX_RAM_BANK_SIZE);

    I've asked you specifically to do this:

	gd->ram_size = get_ram_size((volatile long *)CONFIG_SYS_SDRAM_BASE,
				    CONFIG_MAX_RAM_BANK_SIZE);

> Thanks,
> seedshope

WBR, Sergei


More information about the U-Boot mailing list