[U-Boot] [PATCH 4/4] powerpc: Add LINK_OFF calls in early C-code.

[Wolfgang Denk]

Dear Joakim Tjernlund,

In message <OF6A573B77.9119DEB0-ONC1257814.0069A574-C1257814.007532C7 at transmode.se> you wrote:
>
> > > It would break only if link address != load address. That is, if you
> > > want to use my new CONFIG_SYS_TRUE_PIC feature and be able to load
> > > u-boot at any address regardless of link address you would
> > > have to add LINK_OFF calls into print_83xx_arb_event() too if
> > > you want to use it.
> >
> > Doesn't this add a requirement for future generic pre-relocation code to
> > comply with, to avoid breaking your board?
> 
> Yes, but I don't mind if my board breaks from time to time. After all it isn't
> in u-boot so I have had to deal with quite a few breakages already.
> It is my hope this new feature will spread to other boards as time
> pass.

You mean you ask to add code that is not only highly fragile but even
known to be broken for other boards than yours, and the only board
that uses the feature and has been tested with it "isn't in u-boot" ?

Sorry, but it makes no sense to me to add all this.  NAK.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I am pleased to see that we have differences.  May we together become
greater than the sum of both of us.
	-- Surak of Vulcan, "The Savage Curtain", stardate 5906.4