[U-Boot] [PATCH v2 2/2] armv7: add support for s5pc210 universal board

[Wolfgang Denk]

Dear Minkyu Kang,

In message <4D2ED0E1.7090001 at samsung.com> you wrote:
> This patch adds support for Samsung s5pc210 universal board
> 
> Signed-off-by: Minkyu Kang <mk7.kang at samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
...
> diff --git a/MAKEALL b/MAKEALL
> index a732e6a..a5b265f 100755
> --- a/MAKEALL
> +++ b/MAKEALL
> @@ -434,6 +434,7 @@ LIST_ARMV7="		\
>  	omap4_panda		\
>  	omap4_sdp4430		\
>  	s5p_goni		\
> +	s5pc210_universal	\
>  	smdkc100		\

NO - boards don't get added to MAKEALL any more. MAKEALL automatically
picks them up from boards.cfg.  Please remove.

...
> --- /dev/null
> +++ b/board/samsung/universal_c210/config.mk
...
> +CONFIG_SYS_TEXT_BASE = 0x44800000

No. Please remove config.mk and define CONFIG_SYS_TEXT_BASE in your
board config file instead.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If I don't document something, it's usually either for a good reason,
or a bad reason.  In this case it's a good reason.  :-)
                 - Larry Wall in <1992Jan17.005405.16806 at netlabs.com>