[U-Boot] [PATCH] spi: add support SuperH SPI module
Yoshihiro Shimoda
yoshihiro.shimoda.uh at renesas.com
Tue Jan 18 08:40:51 CET 2011
Hi, Iwamatsu-san,
Thank you for your review.
2011/01/17 19:28, Nobuhiro Iwamatsu wrote:
> Hi, Shioda-san.
>
> 2011/1/17 Yoshihiro Shimoda <yoshihiro.shimoda.uh at renesas.com>:
>> +#define SPI_TBR 0x00
>> +#define SPI_RBR 0x00
>> +#define SPI_CR1 0x08
>> +#define SPI_CR2 0x10
>> +#define SPI_CR3 0x18
>> +#define SPI_CR4 0x20
< snip >
> Please add prefix of "SH_".
Yes, I will add it.
>> +int spi_cs_is_valid(unsigned int bus, unsigned int cs)
>> +{
>> + return 1;
>> +}
>
> Why does this function return "1" every time?
Oh, it's temporary code. I will fix this function.
Best regards,
Yoshihiro Shimoda
More information about the U-Boot
mailing list