[U-Boot] [PATCH v4 7/8] imximage: Add MX53 boot image support

[Wolfgang Denk]

Dear Jason Liu,

In message <AANLkTiny2u9cvFwjURnMOeWAzQxLceyQLpW__Dgupx6e at mail.gmail.com> you wrote:
> > ...
> >>  static table_entry_t imximage_cmds[] = {
> >> +     {CMD_IMAGE_VERSION,     "IMAGE_VERSION",        "i> mage version", },
> >>       {CMD_BOOT_FROM,         "BOOT_FROM",        >     "boot command", },
> >>       {CMD_DATA,              "DATA",       >           "Reg Write Data", },
> >>       {-1,            "",               >       "",     },
> >
> > Can we please keep the table sorted?
>
> what does the "keep the table sorted" mean?

Sorted means that the entries should be sorted, and sort order is "B",
"D", "I".

> I think this function does not need return something, I will fix as
> following, is it OK,
>
> static void set_dcd_rst_v1(struct imx_header *imxhdr, uint32_t dcd_len,
>                                                 char *name, int lineno)
> {
>         dcd_v1_t *dcd_v1 = &imxhdr->header.hdr_v1.dcd_table;
>
>         if (dcd_len > MAX_HW_CFG_SIZE_V1) {
>                 fprintf(stderr, "Error: %s[%d] -"
>                         "DCD table exceeds maximum size(%d)\n",
>                         name, lineno, MAX_HW_CFG_SIZE_V1);
>                + exit(EXIT_FAILURE);
>         }

That's fine with me.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There is nothing new under the sun, but there are lots of old things
we don't know yet."                                  - Ambrose Bierce