[U-Boot] [PATCH 4/4] powerpc: Add LINK_OFF calls in early C-code.

[Wolfgang Denk]

Dear Joakim Tjernlund,

In message <OFBBE91305.B19350D9-ONC125781C.007192FC-C125781C.007421BB at transmode.se> you wrote:
>
> Ah, finally you make sense to me. I actually tested this with mainline
> on my board so it is not completely untested in mainline.

As your board itself is not in mainline this _is_ completely untested
for mainline.

> > It's a nice and appreciated RFC patch or even example implementation,
> > but I fail to see arguments why we should add this to mainline.
> 
> Well, you have to start somewhere and as this involves asm changes
> in start.S it would be pretty dangerous add these without being able to
> test. The idea is that once some version of this patch is in, interested
> parties can apply the same concept on their boards too.

Such testing can be done anywhere, in some test branch. I don't think
mainline is the right place for such an intrusive and experiemental
feature.

> Finally, I would like to remind you about
>  [PATCH] PowerPC: Move -fPIC flag to common place

I have not seen any test reports on this, so I hesitate to apply it
(the move to a common place is no problem, of course, but I'm not
sure about changing -fPIC into -fpic). I think I remember problems
with this in the past; there have even been commits to "use '-fPIC'
_instead_ of '-mrelocatable'" in the past. I don't remember the
details, but I'd like to see some independent testing before this
goes in.

>  [PATCH] PowerPC: Add support for -msingle-pic-base

Same here. This hits a large number of boards, but I have seen zero
test reports.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Do you suppose the reason the ends of the `Intel Inside'  logo  don't
match up is that it was drawn on a Pentium?