[U-Boot] [PATCH] Net: Add Intel E1000 82574L PCIe card support

[Kumar Gala]

On Jan 18, 2011, at 4:33 PM, Wolfgang Denk wrote:

> Dear Roy Zang,
> 
> In message <1295351719-2687-1-git-send-email-tie-fei.zang at freescale.com> you wrote:
>> Add Intel E1000 82574L PCIe card support. Test on MPC8544DS
>> and MPC8572 board.
>> Add the missing contact information for future support.
>> 
>> Signed-off-by: Roy Zang <tie-fei.zang at freescale.com>
>> ---
>> 
>> based on commit e1ccf97c5d7651664d37c0c5aa243874b8851b2d
>> drivers/net/e1000.c |   35 +++++++++++++++++++++++++++--------
>> drivers/net/e1000.h |   11 +++++++++++
>> include/pci_ids.h   |    1 +
>> 3 files changed, 39 insertions(+), 8 deletions(-)
>> 
>> diff --git a/drivers/net/e1000.c b/drivers/net/e1000.c
>> index 5f390bd..a545cd1 100644
>> --- a/drivers/net/e1000.c
>> +++ b/drivers/net/e1000.c
>> @@ -40,6 +40,10 @@ tested on both gig copper and gig fiber boards
>>  *  Copyright (C) Linux Networx.
>>  *  Massive upgrade to work with the new intel gigabit NICs.
>>  *  <ebiederman at lnxi dot com>
>> + *
>> + *  Copyright 2009, 2011 Freescale Semiconductor, Inc.
>> + *  Authors: Roy Zang <tie-fei.zang at freescale.com>
>> + *     - Add PCI Express card support in Jul. 2009
>>  */
> 
> Jul. 2009 ???
> 
>> diff --git a/drivers/net/e1000.h b/drivers/net/e1000.h
>> index eb0804b..4c60b70 100644
>> --- a/drivers/net/e1000.h
>> +++ b/drivers/net/e1000.h
>> @@ -24,12 +24,18 @@
>>   Linux NICS <linux.nics at intel.com>
>>   Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
>> 
>> +
>> *******************************************************************************/
> 
> Please drop the additional blank line
> 
>> +/* Copyright 2009, 2011 Freescale Semiconductor, Inc.
>> + * Authors: Roy Zang <tie-fei.zang at freescale.com>
>> + *       - Add PCI Express card support in Jul. 2009
>> + */
> 
> If you really insist on adding this, thenmove it up into the header.
> What what exactly do you claim Copyright for - for these 4 lines of
> "code"?
> 
> Also, is this really  Jul. 2009?
> 

I think Roy is referencing the following commit in which he added support for numerous e1000 PCIe variants:

commit aa0707897c49c330b7d6b8d8362e44f60f224732
Author: Roy Zang <tie-fei.zang at freescale.com>
Date:   Fri Jul 31 13:34:02 2009 +0800

    Add Intel E1000 PCIE card support

- k