[U-Boot] [PATCH] Net: Add Intel E1000 82574L PCIe card support

Zang Roy-R61911 R61911 at freescale.com
Wed Jan 19 04:42:50 CET 2011



> -----Original Message-----
> From: Wolfgang Denk [mailto:wd at denx.de]
> Sent: Wednesday, January 19, 2011 6:33 AM
> To: Zang Roy-R61911
> Cc: u-boot at lists.denx.de; Gala Kumar-B11780
> Subject: Re: [U-Boot] [PATCH] Net: Add Intel E1000 82574L PCIe card support
> 
> Dear Roy Zang,
> 
> In message <1295351719-2687-1-git-send-email-tie-fei.zang at freescale.com> you
> wrote:
> > Add Intel E1000 82574L PCIe card support. Test on MPC8544DS
> > and MPC8572 board.
> > Add the missing contact information for future support.
> >
> > Signed-off-by: Roy Zang <tie-fei.zang at freescale.com>
> > ---
[snip]

> > diff --git a/drivers/net/e1000.h b/drivers/net/e1000.h
> > index eb0804b..4c60b70 100644
> > --- a/drivers/net/e1000.h
> > +++ b/drivers/net/e1000.h
> > @@ -24,12 +24,18 @@
> >    Linux NICS <linux.nics at intel.com>
> >    Intel Corporation, 5200 N.E. Elam Young Parkway, Hillsboro, OR 97124-6497
> >
> > +
> >
> ******************************************************************************
> */
> 
> Please drop the additional blank line
> 
> > +/* Copyright 2009, 2011 Freescale Semiconductor, Inc.
> > + * Authors: Roy Zang <tie-fei.zang at freescale.com>
> > + *       - Add PCI Express card support in Jul. 2009
> > + */
> 
> If you really insist on adding this, thenmove it up into the header.


In fact, my original internal code put it to the header, but when I check it with checkpatch.pl, I will get a warning such as:
WARNING: please, no spaces at the start of a line
#156: FILE: drivers/net/e1000.h:5:
+  Copyright 2011 Freescale Semiconductor, Inc.$

How to balance?
Thanks.
Roy




More information about the U-Boot mailing list