[U-Boot] [PATCH v4 1/1] imximage: Add MX53 boot image support

[Jason Liu]

Hi, Wolfgang,

2011/1/19 Wolfgang Denk <wd at denx.de>:
> Dear Jason Liu,
>
> In message <1295382963-32356-1-git-send-email-r64343 at freescale.com> you wrote:
>> This patch add the MX53 boot image support.
>>
>> This patch has been tested on Freescale MX53EVK board
>> and MX51EVK board.
>>
>> Signed-off-by: Jason Liu <r64343 at freescale.com>
>>
>> ---
>> Changes for v2:
>> - Address the following comments from Stefano,
>>   - Get rid of  #ifdef in the imximage.h and .c file and use
>>     the runtime check for imximage version
>>   - Document the IMXIMAGE_VERSION definiton in doc/README.imximage
>>   - Move mx53evk/config.mk and mx53evk/imximage.cfg to MX53EVK board
>>     support patch.
>>
>> Changes for v3:
>> - Address the following comments from Stefano,
>>  - Not change the mx51evk file. The code should take VERSION=1 as default,
>>    and we do not need to change the actual boards.
>>  - add a note in the documentation and raise an error in code if the
>>    VERSION command is read after any other suitable commands.
>>  - Change command IMXIMAGE_VERSION simply to IMAGE_VERSION
>>  - Need recognize the version directly from its structure and not storing the
>>    version into the header when do header verify and print.
>>  - Use function pointer to simpliy the code when the version of header is recognized
>> Changes for v4:
>> - Address the following comments from Wolfgang,
>>  - Keep the imximage_cmds table sorted,
>>  - Add braces for (expx) && (expy) gloably,
>
> really? see below.
>
>>  - Return failure to upper call if met errors for function
>>  - Add comments for function set_dcd_rst_v1 alike,
>>  - Re-orgnize code to avoid deep nesting,
>> ---
> ...
>> +     if ((fhdr_v1->app_code_barker == APP_CODE_BARKER) &&
>> +             (hdr_v1->dcd_table.preamble.barker == DCD_BARKER))
>> +
>> +             return IMXIMAGE_V1;
>> +
>> +     /* Try to detect V2 */
>> +     if ((fhdr_v2->header.tag == IVT_HEADER_TAG) &&
>> +             (hdr_v2->dcd_table.header.tag == DCD_HEADER_TAG))
>> +
>> +             return IMXIMAGE_V2;
>
> These two need braces.

Could you please state clear where it need brace? Thanks,

>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Administration: An ingenious abstraction  in  politics,  designed  to
> receive the kicks and cuffs due to the premier or president.
> - Ambrose Bierce
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>