[U-Boot] [PATCH V2 08/11] SPI: mxc_spi: fix swapping bug and add missing swapping in unaligned rx case

Wolfgang Denk wd at denx.de
Thu Jan 20 10:32:14 CET 2011


Dear Stefano Babic,

In message <1295513194-16158-9-git-send-email-sbabic at denx.de> you wrote:
> From: Anatolij Gustschin <agust at denx.de>
> 
> We need to shift only one time in each cycle in the swapping loop
> for unaligned tx case. Currently two byte shift operations are
> performed in each loop cycle causing zero gaps in the transmited
> data, so not all data scheduled for transmition is actually
> transmited.
> 
> The proper swapping in unaligned rx case is missing, so add it
> as we need to put the received data into the rx buffer in the
> correct byte order.
> 
> Signed-off-by: Anatolij Gustschin <agust at denx.de>
> Tested-by: Stefano Babic <sbabic at denx.de>

Checkpatch says:

	[U-Boot] [PATCH V2 08/11] SPI: mxc_spi: fix swapping bug and add
	total: 0 errors, 1 warnings, 22 lines checked

Please have a look.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The complexity of software is an essential property, not an  acciden-
tal  one. Hence, descriptions of a software entity that abstract away
its complexity often abstract away its essence.    - Fred Brooks, Jr.


More information about the U-Boot mailing list