[U-Boot] [PATCH] powerpc/85xx: Add SERDES support for P1010/P1014

[Wolfgang Denk]

Dear Prabhakar Kushwaha,

In message <1295515858-4011-1-git-send-email-prabhakar at freescale.com> you wrote:
> Add the ability to determine if a given IP block connected on SERDES is
> configured. This is useful for things like PCIe and SRIO since they are only
> ever connected on SERDES.
...
> +void fsl_serdes_init(void)
> +{
> +	volatile ccsr_gur_t *gur = (void *)CONFIG_SYS_MPC85xx_GUTS_ADDR;

Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
While most peoples' opinions change, the conviction of their correct-
ness never does.