[U-Boot] [PATCH v3 1/2] armv7: add support for S5PC210 SoC

[Wolfgang Denk]

Dear Minkyu Kang,

In message <4D382F3E.6080000 at samsung.com> you wrote:
> S5PC210 is a 32-bit RISC and Cortex-A9 Dual Core based micro-processor.
...
> new file mode 100644
> index 0000000..69011fc
> --- /dev/null
> +++ b/arch/arm/include/asm/arch-s5pc2xx/uart.h
...
> +static int use_divslot = 0;

This is certainly wrong in a header file.

Also, please do not initialise statics to 0 or NULL.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The evolution of the human race will not be accomplished in  the  ten
thousand  years  of  tame  animals,  but in the million years of wild
animals, because man is and will always be a wild animal.
                                              - Charles Galton Darwin