[U-Boot] [PATCH v2 2/2] armv7: add support for s5pc210 universal board

[Wolfgang Denk]

Dear seedshope,

In message <4D3841B2.8050102 at gmail.com> you wrote:
...
> > +int dram_init(void)
> > +{
> > +	gd->ram_size = PHYS_SDRAM_1_SIZE + PHYS_SDRAM_2_SIZE;
> It is shoule to use get_ram_size() function

This, like the others, are valid comments - but:

Can you please explain why you have to quote all the 1000+
unrelated lines of the patch?

It is even difficult to spot your 4 lines of comments in 1000+ lines
of quoted patch.  Plase don't do that.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
He had quite a powerful intellect, but it  was  as  powerful  like  a
locomotive,  and  ran on rails and was therefore almost impossible to
steer.                          - Terry Pratchett, _Lords and Ladies_