[U-Boot] ??: [PATCH v2] include/linux/mii.h: update for supporting GE
Wolfgang Denk
wd at denx.de
Fri Jan 21 09:23:12 CET 2011
Dear Macpaul,
In message <50FD90C65C53FB45BADEEBCD84FF07F202CEB58B at ATCPCS06.andestech.com> you wrote:
>
> > /home/wd/git/u-boot/work/include/linux/mii.h:134:1: warning:
> > "LPA_1000HALF" redefined
> > In file included from uec_phy.c:26:
> > uec_phy.h:35:1: warning: this is the location of the previous
> > definition
> > text data bss dec hex filename
> > 327682 28828 230568 587078 8f546 /work/wd/tmp-ppc/u-boot
>
> Moreover, after checking drivers/qe/uec_phy.h, I've found
> some definitions differs from standard linux code.
>
> In uec_phy:
> drivers/qe/uec_phy.h:34:#define LPA_1000FULL 0x0400
> drivers/qe/uec_phy.h:35:#define LPA_1000HALF 0x0200
>
> In Linux:
> include/linux/mii.h:133:#define LPA_1000FULL 0x0800 /* Link partner 1000BASE-T full duplex */
> include/linux/mii.h:134:#define LPA_1000HALF 0x0400 /* Link partner 1000BASE-T half duplex */
>
> Do you know if this is a wrong defintion on uec_phy ?
> I'm afraid the fix will lead some mis-behavior for boards has uec_phy.
These definitions were added by commit 91cdaa3a:
commit 91cdaa3a9d7562b869d96774e9c9ddf142c0848d
Author: Anton Vorontsov <avorontsov at ru.mvista.com>
Date: Mon Mar 24 20:46:24 2008 +0300
uec: add support for gbit mii status readings
Signed-off-by: Anton Vorontsov <avorontsov at ru.mvista.com>
Anton, can you please comment?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There's no honorable way to kill, no gentle way to destroy. There is
nothing good in war. Except its ending.
-- Abraham Lincoln, "The Savage Curtain", stardate 5906.5
More information about the U-Boot
mailing list