[U-Boot] [v4 patch 6/6] SMDK6400: Fix SMDK6400 SDRAM init

seedshope bocui107 at gmail.com
Fri Jan 21 19:05:38 CET 2011


On 01/22/2011 01:52 AM, Sergei Shtylyov wrote:
> Hello.
>
> seedshope wrote:
>
>> Since SDRAM init function have already change, So the SDRAM
>> initial function must be change.
>
>    This description sounds somewhat tautological...
If I describe  as following:
Since SDRAM init function have already change, Modify SDRAM inital
function to adapt to it.

How about it?
>
>> Signed-off-by: seedshope <bocui107 at gmail.com>
>
>    Your real name is required in the signoff.
I use the name for my pen name. It is not problem.
>
>> ---
>>  board/samsung/smdk6400/smdk6400.c |   10 +++++++++-
>>  1 files changed, 9 insertions(+), 1 deletions(-)
>
>> diff --git a/board/samsung/smdk6400/smdk6400.c 
>> b/board/samsung/smdk6400/smdk6400.c
>> index 35aa40b..1d03b7a 100644
>> --- a/board/samsung/smdk6400/smdk6400.c
>> +++ b/board/samsung/smdk6400/smdk6400.c
>> @@ -78,10 +78,18 @@ int board_init(void)
>>      return 0;
>>  }
>>
>> -int dram_init(void)
>> +void dram_init_banksize(void)
>>  {
>> +    DECLARE_GLOBAL_DATA_PTR;
>> +
>>      gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
>>      gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
>> +}
>> +
>> +int dram_init(void)
>> +{
>> +    gd->ram_size = get_ram_size((long *)CONFIG_SYS_SDRAM_BASE,
>> +            PHYS_SDRAM_1_SIZE);
>
>   Could you move this last line more to the right?
Ya, the orig is ok, But I re-do the patch, It is miss. sorry.

Thanks
seedshope
>
> WBR, Sergei



More information about the U-Boot mailing list