[U-Boot] [PATCH v3] arm926ejs: timer: Replace bss variable by gdr
Alexander Holler
holler at ahsoftware.de
Sat Jan 22 06:39:39 CET 2011
Hello,
Am 21.01.2011 09:56, schrieb Heiko Schocher:
> -static ulong timestamp;
> -static ulong lastdec;
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +#define timestamp gd->tbl
> +#define lastdec gd->lastinc
I'm the only one who doesn't like such defines? They might be handy for
quick fixes, but in regard to style and readablity I don't like them.
When looking at teh code where they will used, you won't see the actual
place where they are stored. And in more complex expression they might
become dangerous to use because they hide the operator "->".
Regards,
Alexander
More information about the U-Boot
mailing list