[U-Boot] board/Marvell/DB64360
Prafulla Wadaskar
prafulla at marvell.com
Mon Jan 24 20:50:42 CET 2011
> -----Original Message-----
> From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de]
> On Behalf Of Tim Liu
> Sent: Monday, January 24, 2011 11:27 AM
> To: u-boot at lists.denx.de
> Subject: Re: [U-Boot] board/Marvell/DB64360
>
> Hi,
>
>
>
> I am new to the list, any info. Or help is appreciated!
>
>
>
> I went through C code of Ethernet initialization of U-boot(version
> u-boot-2010_09.tar.gz ) in the board of db64360 under the board name
> Marvell and found that there maybe is an obvious coding error in the
> function void mv64360_eth_initialize(bd_t *bis) located in mv_eth.c. The
> line is underscored.
>
> The line should be: port_private = calloc (sizeof (struct
> mv64360_eth_priv), 1), because it make next line pointless:
> ethernet_private->port_private = (void *)port_private;
> ethernet_private->port_private should point to mv64360_eth_priv, but
> actually point to (*ethernet_private)ETH_PORT_INFO in the code.
>
This is a very old board support and not up to the mark (maintained).
I don't have hardware, if there are no users, we can remove it's support.
Copying Josh (Maintainer of this board)
Hi Josh
What do you think?
Regards..
Prafulla . .
More information about the U-Boot
mailing list