[U-Boot] [PATCH v5 1/1] imximage: Add MX53 boot image support

Jason Liu liu.h.jason at gmail.com
Tue Jan 25 08:56:31 CET 2011


Hi, Wolfgang,

2011/1/20 Jason Liu <r64343 at freescale.com>:
> This patch add the MX53 boot image support.
>
> This patch has been tested on Freescale MX53EVK board
> and MX51EVK board.
>
> Signed-off-by: Jason Liu <r64343 at freescale.com>
>
> ---
> Changes for v2:
> - Address the following comments from Stefano,
>  - Get rid of  #ifdef in the imximage.h and .c file and use
>    the runtime check for imximage version
>  - Document the IMXIMAGE_VERSION definiton in doc/README.imximage
>  - Move mx53evk/config.mk and mx53evk/imximage.cfg to MX53EVK board
>    support patch.
>
> Changes for v3:
> - Address the following comments from Stefano,
>  - Not change the mx51evk file. The code should take VERSION=1 as default,
>   and we do not need to change the actual boards.
>  - add a note in the documentation and raise an error in code if the
>   VERSION command is read after any other suitable commands.
>  - Change command IMXIMAGE_VERSION simply to IMAGE_VERSION
>  - Need recognize the version directly from its structure and not storing the
>   version into the header when do header verify and print.
>  - Use function pointer to simpliy the code when the version of header is recognized
> Changes for v4:
> - Address the following comments from Wolfgang,
>  - Keep the imximage_cmds table sorted,
>  - Add braces for (expx) && (expy) gloably,
>  - Return failure to upper call if met errors for function
>  - Add comments for function set_dcd_rst_v1 alike,
>  - Re-orgnize code to avoid deep nesting,
> Changes for v5:
>  - Remove the blank line before the only one line statement and
>  not using braces for the one line statment for the sake of the
>  same coding style of this file. For example,
>  if (!exp)
>        return ret;
> ---
>  doc/README.imximage |   12 +-
>  tools/imximage.c    |  525 +++++++++++++++++++++++++++++++++++++--------------
>  tools/imximage.h    |  110 +++++++++--
>  3 files changed, 487 insertions(+), 160 deletions(-)
>

Any feedback about this patch?

>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>


More information about the U-Boot mailing list