[U-Boot] [PATCH V2 4/5] mvmfp: add MFP configuration support for PANTHEON

Wolfgang Denk wd at denx.de
Wed Jan 26 08:39:30 CET 2011


Dear Lei Wen,

In message <AANLkTikKdESNw=7bnpcR8Yr8TZtD=Q=MmGGNd9ELJBBj at mail.gmail.com> you wrote:
> 
> >> This patch adds the support MFP support for Marvell PANTHEON SoCs
> >
> > "the support MFP support" ??
> >
> > Please fix. Also, please explain what MFP is. It may be obvious to
> > you, it ain't so for me.
> >
> >> +/*
> >> + * Frequently used MFP Configuration macros for all PANTHEON family of
> >> +SoCs
> >
> > Line wrapped - please fix.
> >
> >
> This already fixed in the v6 patch, maybe you didn't notice this...
> http://patchwork.ozlabs.org/patch/80307/

Only the line wrap was fixed.  

The other 2 remarks still apply.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I'm a programmer: I don't buy software, I write it.
                                                  -- Tom Christiansen


More information about the U-Boot mailing list