[U-Boot] [PATCH v2 1/3] Fix at91 includes in soft_i2c driver

Reinhard Meyer u-boot at emk-elektronik.de
Wed Jan 26 09:18:54 CET 2011


Dear Ryan Mellon, dear Heiko Schocher:
>>>>> Signed-off-by: Ryan Mallon<ryan at bluewatersys.com>
>>>>> ---
>>>>>   drivers/i2c/soft_i2c.c |    4 +---
>>>>>   1 files changed, 1 insertions(+), 3 deletions(-)
>>>>
>>>> I think this one goes through as a bug fix, i. e. for the upcoming
>>>> release.
>>>>
>>>> The other patches of this series go into next.
>>>
>>> Ok. Reinhard? Do you pick up this patch? If so, I give my:
>>>
>>> Acked-by: Heiko Schocher<hs at denx.de>
>>
>> I was going to complain that it was not alphabetically sorted as I
>> suggested to him,
>> however I am now considering to remove the AT91RM9200 case altogether.
>> That one has to be forced into AT91FAMILY.
>>
>> Once corrected, I will pickup this patch then.

I made up my mind, it should only test for AT91FAMILY.

AT91RM9200 is supposed to join AT91FAMILY anyway, so lets do this correctly right now.

#if defined(CONFIG_AT91FAMILY)

If its done that way, here is my
Acked-by: Reinhard Meyer<u-boot at emk-elektronik.de>

Ryan, can you please change it as such, and preferably post it as a separate
patch (not with your new board)? So Heiko can pick it up and make it go as a
bug fix to mainline faster than I could do it right now through the "atmel" tree.

Best Regards,
Reinhard


More information about the U-Boot mailing list