[U-Boot] [PATCH] ARM: fix broken build of ARM

[Alexander Holler]

Am 27.01.2011 22:40, schrieb Albert ARIBAUD:
> Le 27/01/2011 22:32, Alexander Holler a écrit :
>> Am 27.01.2011 22:10, schrieb Albert ARIBAUD:
>>> Le 27/01/2011 21:55, Alexander Holler a écrit :
>>>> Am 27.01.2011 21:20, schrieb Albert ARIBAUD:
>>>>> Hi Alexander,
>>>>>
>>>>> Le 27/01/2011 20:42, Alexander Holler a écrit :
>>>>>> Hello,
>>>>>>
>>>>>> Am 27.01.2011 17:03, schrieb Stefano Babic:
>>>>>>> Commit 8aba9dceebb14144e07d19593111ee3a999c37fc breaks
>>>>>>> ARM boards because for ARM the -pie option is used
>>>>>>> for partial linking together with -r option.
>>>>>>>
>>>>>>> The patch adds the -pie option to link u-boot.bin only.
>>>>>>
>>>>>> Using native compilation with gcc 4.5.2 and binutils 2.21 this patch
>>>>>> will result in an unusable u-boot. It halts here after DRAM: ... just
>>>>>> like it was before some relocation fixes (regarding binutils).
>>>>>
>>>>> Which board do you compile?
>>>>
>>>> Upps, sorry, that one was on a BeagleBoard (armv7, omap3).
>>>
>>> I've just tried the following to compare make logs of before commit
>>> 8aba9dceebb14144e07d19593111ee3a999c37fc on the one hand and after this
>>> commit and with the proposed fix on the other hand:
>>
>> Oh, it seems I've got misunderstood, the patch from Stefano Babic breaks
>> u-boot here and not the commit 8aba9dceebb14144e07d19593111ee3a999c37fc.
>
> I think I understood you: what I do is compile without commit 8aba9dce
> on the one hand, and with it _plus Stefano's patch_ on the other hand,
> in order to see how things compiled before we split LDFLAGS (8aba9dce^)
> with how things compile if we split LDFLAGS (8aba9dce) with -pie in the
> right place (Stefano's patch).
>
> Can you try that?

Sorry, again. While hunting another problem I've applied Stefano's patch 
but haven't had 8aba9dceebb14144e07d19593111ee3a999c37fc (I was on the 
wrong branch here).
I've now rebased to the master (which includes the above commit) and 
applied Stefano's patch and it works.

Sorry for the noise.

Regards,

Alexander