[U-Boot] [PATCH 5/8 v3] P1021: add P1021MDS board support

Scott Wood scottwood at freescale.com
Fri Jan 28 20:13:59 CET 2011


On Fri, 28 Jan 2011 13:06:28 -0600
Timur Tabi <timur at freescale.com> wrote:

> > +void putc(char c)
> > +{
> > +       if (c == '\n')
> > +               NS16550_putc((NS16550_t)CONFIG_SYS_NS16550_COM1, '\r');
> > +
> > +       NS16550_putc((NS16550_t)CONFIG_SYS_NS16550_COM1, c);
> > +}
> > +
> > +void puts(const char *str)
> > +{
> > +       while (*str)
> > +               putc(*str++);
> > +}
> 
> These look like functions that shouldn't be in board-specific code.

That's been established practice in the SPL board files so far, though
I suppose it could be factored out to its own file.

-Scott



More information about the U-Boot mailing list