[U-Boot] [PATCH 2/2] at91sam9261ek: make operational again

Remy Bohmer linux at bohmer.net
Fri Jan 28 21:38:15 CET 2011


Hi,

>> -COBJS-y += at91sam9261ek.o
>> +COBJS-y += $(BOARD).o
>>   COBJS-y += led.o
>>   COBJS-$(CONFIG_HAS_DATAFLASH) += partition.o
>>
>> -SRCS := $(SOBJS:.o=.S) $(COBJS-y:.o=.c)
>> -OBJS := $(addprefix $(obj),$(COBJS-y))
>> -SOBJS        := $(addprefix $(obj),$(SOBJS))
>> +SRCS := $(SOBJS-y:.o=.S) $(COBJS-y:.o=.c)
>> +OBJS := $(addprefix $(obj),$(COBJS-y) $(SOBJS-y))
>> +SOBJS        := $(addprefix $(obj),$(SOBJS-y))
>
> What is the rationale for putting both C *and* assembly language objects
> in OBJS?

No rationale, except made this Makefile more in line with another board.
Reworked, will be in patch-v2

>>
>> -#define CONFIG_STACKSIZE     (32*1024)       /* regular stack */
>> +#define CONFIG_STACKSIZE     (SZ_32K)        /* regular stack */
>
> Do not use SZ_ constants -- several instances in this patch.

Reverted these changes in patch-v2.
Thanks.

Kind regards,

Remy


More information about the U-Boot mailing list