[U-Boot] [PATCH 4/6] powerpc/p1021: add more P1021 defines.

Wolfgang Denk wd at denx.de
Mon Jan 31 21:07:35 CET 2011


Dear Haiying.Wang at freescale.com,

In message <1296499317-26616-5-git-send-email-Haiying.Wang at freescale.com> you wrote:
> From: Haiying Wang <Haiying.Wang at freescale.com>
> 
> Signed-off-by: Haiying Wang <Haiying.Wang at freescale.com>
> ---
>  arch/powerpc/include/asm/immap_85xx.h |    6 ++++++
>  arch/powerpc/include/asm/immap_qe.h   |    9 +++++++--
>  2 files changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/include/asm/immap_85xx.h b/arch/powerpc/include/asm/immap_85xx.h
> index 6bd83ba..77e3629 100644
> --- a/arch/powerpc/include/asm/immap_85xx.h
> +++ b/arch/powerpc/include/asm/immap_85xx.h
> @@ -1948,6 +1948,12 @@ typedef struct ccsr_gur {
>  	u8	res10b[76];
>  	par_io_t qe_par_io[7];
>  	u8	res10c[1600];
> +#elif defined(CONFIG_P1021)
> +	u8      res10b1[12];
> +	u32     iovselsr;
> +	u8      res10b2[60];
> +	par_io_t qe_par_io[3];
> +	u8      res10c[1496];
>  #else

res10b1? Two levels of insertions already. Isn't it time to renumber
the reserved fields?


> @@ -601,13 +604,15 @@ extern qe_map_t *qe_immr;
>  #define QE_MURAM_SIZE		0x10000UL
>  #elif defined(CONFIG_MPC8569)
>  #define QE_MURAM_SIZE		0x20000UL
> +#elif defined(CONFIG_P1021)
> +#define QE_MURAM_SIZE          0x6000UL
>  #elif defined(CONFIG_MPC8360)
>  #define QE_MURAM_SIZE		0xc000UL
>  #elif defined(CONFIG_MPC832x)
>  #define QE_MURAM_SIZE		0x4000UL
>  #endif

Can you please keep the "if defined(..)" list sorted? Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If you want strict real-time behavior, run in the real  time  schedu-
ling class.  But there are no seatbelts or airbags;  main(){for(;;);}
can hard hang your system.                          -- Bart Smaalders


More information about the U-Boot mailing list