[U-Boot] [PATCH 3/6] P1021: add P1021MDS board support

[Scott Wood]

On Mon, 31 Jan 2011 21:03:17 +0100
Wolfgang Denk <wd at denx.de> wrote:

> > +/*
> > + * Environment Configuration
> > + */
> > +#define CONFIG_HOSTNAME	p1021mds
> > +#define CONFIG_ROOTPATH	/nfsroot
> > +#define CONFIG_BOOTFILE	your.uImage
> 
> Please rather omit the setting instead of using fillers that are of no
> practical value.

Well, they do make it easier for a user to quickly see what the names
are that U-Boot expects for such commonly used things, rather than
having to scan the manual.

> > +#define CONFIG_LOADADDR	1000000   /*default location for tftp and bootm*/
> > +
> > +#define CONFIG_BOOTDELAY 10       /* -1 disables auto-boot */
> > +#undef  CONFIG_BOOTARGS           /* the boot command will set bootargs*/
> > +
> > +#define	CONFIG_EXTRA_ENV_SETTINGS					\
> > +	"netdev=eth0\0"							\
> > +	"consoledev=ttyS0\0"						\
> > +	"ramdiskaddr=2000000\0"						\
> > +	"ramdiskfile=your.ramdisk.u-boot\0"				\
> 
> Ditto. [BTW: why "....ramdisk.u-boot"? U-Boot does not use ramdisks.
> The ramdisk is only used for some OS, so that should probably be
> "...ramdisk.linux" instead?]

We often use the ".u-boot" suffix on ramdisks that have been wrapped
with a uImage header.

-Scott