[U-Boot] [PATCH 3/6] P1021: add P1021MDS board support

[Kumar Gala]

On Jan 31, 2011, at 3:39 PM, Haiying Wang wrote:

> On Mon, 2011-01-31 at 21:03 +0100, Wolfgang Denk wrote:
>> Dear Haiying.Wang at freescale.com,
>>> diff --git a/board/freescale/p1021mds/config.mk b/board/freescale/p1021mds/config.mk
>>> new file mode 100644
>>> index 0000000..3888f61
>>> --- /dev/null
>>> +++ b/board/freescale/p1021mds/config.mk
>> ...
>>> +ifndef NAND_SPL
>>> +ifndef IN_TPL
>>> +ifeq ($(CONFIG_NAND), y)
>>> +LDSCRIPT := $(TOPDIR)/$(CPUDIR)/u-boot-nand.lds
>>> +endif
>>> +endif
>>> +endif
>> 
>> Why is this config.mk needed?  Can you not do all this in the board
>> config file instead?
> Do you mean the board header file or arch/powerpc/config.mk? I did not see any LDSCRIPT defined in Freescale board header file.

I think something like:

diff --git a/include/configs/MPC8572DS.h b/include/configs/MPC8572DS.h
index e6b60cf..f2d6cdb 100644
--- a/include/configs/MPC8572DS.h
+++ b/include/configs/MPC8572DS.h
@@ -37,6 +37,7 @@
 #define CONFIG_NAND_U_BOOT
 #define CONFIG_RAMBOOT_NAND
 #ifdef CONFIG_NAND_SPL
+#define CONFIG_SYS_LDSCRIPT "arch/powerpc/cpu/mpc85xx/u-boot-nand.lds"
 #define CONFIG_SYS_TEXT_BASE_SPL 0xfff00000
 #define CONFIG_SYS_MONITOR_BASE        CONFIG_SYS_TEXT_BASE_SPL /* start of mon

- k