[U-Boot] [PATCH 3/6] arm: add __ilog2 function

Wolfgang Denk wd at denx.de
Mon Jul 4 12:13:40 CEST 2011


Dear Rob Herring,

In message <1309275583-11763-4-git-send-email-robherring2 at gmail.com> you wrote:
> From: Rob Herring <rob.herring at calxeda.com>
> 
> Add __ilog2 function for ARM. Needed for ahci.c
> 
> Signed-off-by: Rob Herring <rob.herring at calxeda.com>
> Cc: Albert ARIBAUD <albert.aribaud at free.fr>
> ---
>  arch/arm/include/asm/bitops.h |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/include/asm/bitops.h b/arch/arm/include/asm/bitops.h
> index 270f163..0420182 100644
> --- a/arch/arm/include/asm/bitops.h
> +++ b/arch/arm/include/asm/bitops.h
> @@ -106,6 +106,15 @@ static inline int test_bit(int nr, const void * addr)
>      return ((unsigned char *) addr)[nr >> 3] & (1U << (nr & 7));
>  }
>  
> +extern __inline__ int __ilog2(unsigned int x)

checkpatch says: WARNING: plain inline is preferred over __inline__


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The X11 source code style is ATROCIOUS and should not be used  as  a
model."                                                   - Doug Gwyn


More information about the U-Boot mailing list