[U-Boot] [PATCH 5/6] scsi/ahci: add support for non-PCI controllers

[Wolfgang Denk]

Dear Rob,

In message <4E11D372.8090708 at calxeda.com> you wrote:
> 
> >> -#error no scsi device defined
> >> +#define SCSI_VEND_ID 0
> >> +#define SCSI_DEV_ID  0
> >>  #endif
> > 
> > I'm not sure if this is a good idea.  Please explain.
> 
> This is the PCI ID and is only used here:
> 
> common/cmd_scsi.c:183:
> busdevfunc=pci_find_device(SCSI_VEND_ID,SCSI_DEV_ID,0); /* get PCI
> Device ID */
> 
> For a non-PCI AHCI controller, there is no id. For PCI, I don't think 0
> is a valid vendor ID anyway.

I think we should rather skip the respective parts of the code instead
of inserting invalid vendor IDs.

> > Should this always be compiled in?
> 
> I can add a config option CONFIG_SCSI_AHCI_PLAT. Perhaps this would be
> better than using CONFIG_PCI as I suppose you could have non-PCI AHCI
> controller on a platform with PCI.

Yes, please.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
... bacteriological warfare ... hard to believe we were once foolish
enough to play around with that.
	-- McCoy, "The Omega Glory", stardate unknown