[U-Boot] [PATCH 2/5] Added extra documentation about how the relocation address to RAM is picked for ARM.
Wolfgang Denk
wd at denx.de
Mon Jul 4 21:43:24 CEST 2011
Dear Christopher Harvey,
In message <20110704174348.GC3016 at harvey-pc.matrox.com> you wrote:
> Signed-off-by: Christopher Harvey <charvey at matrox.com>
> ---
> doc/README.arm-relocation | 9 ++++++++-
> 1 files changed, 8 insertions(+), 1 deletions(-)
Please let's stop with ARM specific documatation of things that are
considered generic.
> +The code that picks the location in RAM for ARM can be found in the
> +arch/arm/lib/board.c file under the board_init_f function.
under the function? Who dropped that code? :-) s/under/in/
Also delete "for ARM", and s/arm/<arch>/. This is not ARM specific.
> +The postfix _f means executed from flash, and _r means from RAM.
Maybe we whould rather write "... from NOR flash" to indicate that we
actually mean ROM.
> +The new location is picked with respect to the highest RAM address, and the
> +exact final value depends heavily on compile time options. The source is the
> +best documentation here.
This should be changed, i. e. better documentation should be provided
:-)
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Obviously, a major malfunction has occurred."
-- Steve Nesbitt, voice of Mission Control, January 28,
1986, as the shuttle Challenger exploded within view
of the grandstands.
More information about the U-Boot
mailing list