[U-Boot] [PATCH 3/5] Removed unused define, CONFIG_ARMV7.

Wolfgang Denk wd at denx.de
Mon Jul 4 21:47:15 CEST 2011


Dear Christopher Harvey,

In message <20110704184659.GG3016 at harvey-pc.matrox.com> you wrote:
>
> > Need the empty line that wasn't there before?  Same Q for every file in
> > this patch.
> 
> I generated this patch with sed actually. I could easily re-run it and
> tell it to remove the newlines. Lets see if it gets
> considered/accepted first.

Please fix this (and the other comments), and it goes in.

> > >  #define CONFIG_SYS_TEXT_BASE		0x60800000
> > >  
> > >  /* High Level Configuration Options */
> > > -#define CONFIG_ARMV7			1
> > > +
> > >  
> > 
> > If that was the only remaining high level config option, should the
> > comment be removed?
> 
> I figured maintainers would get to it eventually. 

Such "eventually" never works.  Please go through this manually and
clean up.  Thanks.



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Wenn Du ein' weise Antwort verlangst, Mußt Du vernünftig fragen.
                                                -- Goethe, Invektiven


More information about the U-Boot mailing list