[U-Boot] [PATCH 5/5] Warn when the machine ID isn't passed to an ARM kernel and u-boot is compiled in debug mode. The kernel cannot boot without it.
Wolfgang Denk
wd at denx.de
Tue Jul 5 12:04:37 CEST 2011
Dear Igor Grinberg,
In message <4E12BF5D.6080307 at compulab.co.il> you wrote:
>
> > + debug("\nWarning: machid not set! Linux will not finish booting.\n\n");
> > + }
> > +#endif
>
> Is there a reason to close this in ifdef DEBUG? and also use debug()?
> I would print this in any case, because machid must be set for Linux to boot
> properly.
> This message will not hurt anyone (just add ~50 bytes, this is not an spl code)
> and if someone hacks Linux to boot in any case (without checking the machid),
> then he can also hack U-Boot and remove the message (if it bothers him).
I think "Warning: machid not set" should be sufficient.
Note: we should't print excessive newlines. No \n at the begin of the
string, only one at the end.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"We don't have to protect the environment -- the Second Coming is at
hand." - James Watt
More information about the U-Boot
mailing list