[U-Boot] [PATCH v2] Let source cross-reference targets follow symbolic links

Detlev Zundel dzu at denx.de
Fri Jul 15 17:19:35 CEST 2011


Hi Horst,

> From: Horst Kronstorfer <hkronsto at frequentis.com>
>
> Without telling 'find' to follow symbolic links, files under include/asm
> and arch/$(ARCH)/include/asm/arch are not added to the indexing file list.
>
> Signed-off-by: Horst Kronstorfer <hkronsto at frequentis.com>
>
> Changes for v2:
>     - Apply this change to all source cross-reference targets

This needs to go below the '---' as it is not part of the git commit
message.

> ---
>  Makefile |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index e56fa02..e86a81a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -471,15 +471,17 @@ TAG_SUBDIRS = $(SUBDIRS)
>  TAG_SUBDIRS += $(dir $(__LIBS))
>  TAG_SUBDIRS += include
>  
> +FIND := find -L

I really dislike this approach.  I would never expect a variable $(FIND)
to already include options.  So if you want to go that way then also
introduce FINDFLAGS.

Thanks
  Detlev

-- 
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de


More information about the U-Boot mailing list