[U-Boot] [PATCH 2/2] arm/km: fix u-boot.kwb build breakage

Holger Brunck holger.brunck at keymile.com
Mon Jul 18 11:41:28 CEST 2011


Hi Albert,

On 07/16/2011 12:51 PM, Albert ARIBAUD wrote:
> Le 15/06/2011 09:38, Holger Brunck a écrit :
> 
>> I agree for a single board support, but this is not possible in our approach. We
>> include config_cmd_default.h in keymile-common.h. And keymile-common.h is valid
>> for our powerpc and arm boards. In km_arm.h we add the CMD settings which are
>> only additionaly needed on our arm boards.
> 
> You can #undef things just as you can #define them after including default
> command headers -- I personally see no issue with this.
> 

yes you are right it could be done this way. But I think it's more clearly
arranged if we only define the commands in keymile-common.h wich are common for
all keymile boards rather to define a superset there and undef them later on in
km-powerpc.h or km_arm.h.

Best regards
Holger Brunck



More information about the U-Boot mailing list