[U-Boot] [PATCH 4/7] mmc: rescan fails on empty slot
Jaehoon Chung
jh80.chung at samsung.com
Tue Jul 19 04:06:49 CEST 2011
Hi Michael.
I have some question. there are some mmc_init().
But you are only checked there..
Did you have any special reason?
Regards,
Jaehoon Chung
Michael Jones wrote:
> Fail in 'mmc rescan' if mmc_init() returns error
>
> Signed-off-by: Michael Jones <michael.jones at matrix-vision.de>
> ---
> common/cmd_mmc.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/common/cmd_mmc.c b/common/cmd_mmc.c
> index 176646d..28918f6 100644
> --- a/common/cmd_mmc.c
> +++ b/common/cmd_mmc.c
> @@ -165,9 +165,11 @@ int do_mmcops(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> }
>
> mmc->has_init = 0;
> - mmc_init(mmc);
>
> - return 0;
> + if (mmc_init(mmc))
> + return 1;
> + else
> + return 0;
> } else if (strncmp(argv[1], "part", 4) == 0) {
> block_dev_desc_t *mmc_dev;
> struct mmc *mmc = find_mmc_device(curr_device);
More information about the U-Boot
mailing list