[U-Boot] [PATCH 1/4] gpio: Adds GPIO driver support for Armada100

Ajay Bhargav ajay.bhargav at einfochips.com
Wed Jul 20 08:36:25 CEST 2011


Dear Wolfgang,

> 
> Is there any specific reason for not using u32 for the padding as
> well?
> 
nothing specific. It makes easy to find number of bytes than words.

> 
> Why would you need this BASE + OFFSET notation when using a C struct
> for the registers? Thi smakes little sense to me.
> 

Well I did use the C struct method, if you see my patches submitted earlier
but according to Prafulla and Lie structure size is too big. so they want me
to use a mix of C struct and BASE + OFFSET notation. so I thought to break the big
C struct into smaller grouped structures pointing each group with GPIO base + group
offset. I would be glad if you can suggest me something better or smarter.

Regards,
Ajay Bhargav


More information about the U-Boot mailing list