[U-Boot] [PATCH] powerpc/8xxx: Update USB mode device tree fixup

[Mehresh Ramneek-B31383]

Hi Wolfgang,

I agree with you that there may be some boards that have USB (on soc) but do not use it.

But in that case, they should not define CONFIG_HAS_FSL_DR_USB in their board file.

usb.h file has a logic that if this file is included, and the USB protocol is not defined then it throws compilation error (which is correct because the driver will not be able to perform low level initialization which is specific to a protocol)

The issue here is that we have some boards that are declaring that they have USB (by defining CONFIG_HAS_FSL_DR_USB), but they are not defining the protocol itself. This issue is not related to including <usb.h> file or using any macro from within it.

What's the point of declaring the availability of an IP on a board without mentioning the protocol being used by this IP !!

In case the board is not using USB, CONFIG_HAS_FSL_DR_USB should not be defined in the board file itself.

Even if I make changes for not using a macro defined in <usb.h> file, the issue will still remain for boards defining CONFIG_HAS_FSL_DR_USB (without defining protocol) and using <usb.h> file...

Thanks and Regards,
Ramneek 

-----Original Message-----
From: Wolfgang Denk [mailto:wd at denx.de] 
Sent: Wednesday, July 20, 2011 5:35 PM
To: Mehresh Ramneek-B31383
Cc: Phillips Kim-R1AAHA; Gala Kumar-B11780; u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] powerpc/8xxx: Update USB mode device tree fixup

Dear Mehresh Ramneek-B31383,

In message <16867771548D2F469F1A8F817F38278820AF77 at 039-SN1MPN1-003.039d.mgd.msft.net> you wrote:
> 
> I just checked that this error comes when you don't have any of the following defined in the board file:
> CONFIG_USB_UHCI
> CONFIG_USB_OHCI
> CONFIG_USB_EHCI
> CONFIG_USB_OHCI_NEW
> ...
> MPC837xRDB has EHCI host controller. Hence, CONFIG_USB_EHCI and its relevant support macros should be defined in include/configs/MPC837XERDB.h file.

No, I disagree.  It must be possible to configure such a port without USB as well.  Not all boards based on this processer ever want to use USB (or even have it on their boards).

Please fix this in a way that no such definitions are ever mandatory.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Your csh still thinks true is false. Write to your vendor  today  and tell them that next year Configure ought to "rm /bin/csh" unless they fix  their blasted shell. :-)
                 - Larry Wall in Configure from the perl distribution