[U-Boot] [PATCH] mx53: use CONFIG_SYS_L2CACHE_OFF in config file
Stefano Babic
sbabic at denx.de
Tue Jul 26 11:21:28 CEST 2011
On 07/26/2011 10:25 AM, Jason Liu wrote:
> CONFIG_L2_OFF is obsolete after the following commit:
>
> e47f2db5371047eb9bcd115fee084e6a8a92a239
> armv7: rename cache related CONFIG flags
> Replace the cache related CONFIG flags with more meaningful
> names. Following are the changes:
> CONFIG_L2_OFF -> CONFIG_SYS_L2CACHE_OFF
>
> But the above commit does not clean up all the mx53 board config file.
> This patch does it by using CONFIG_SYS_L2CACHE_OFF instead of _L2_OFF
>
Hi Jason,
I agree that CONFIG_L2_OFF is obsolete and must be removed. However, I
do not see any application of CONFIG_SYS_L2CACHE_OFF.
If I grep into u-boot code, this config is not used at all for i.MX.
Indeed, I can find application for OMAP boards:
arch/arm/cpu/armv7/omap3/board.c:#ifndef CONFIG_SYS_L2CACHE_OFF
arch/arm/cpu/armv7/omap3/board.c:#ifndef CONFIG_SYS_L2CACHE_OFF
arch/arm/cpu/armv7/s5pc1xx/cache.S:#ifndef CONFIG_SYS_L2CACHE_OFF
arch/arm/cpu/armv7/omap4/board.c:#ifndef CONFIG_SYS_L2CACHE_OFF
So this setup is usefulness, I think.
By the way (and I know it is not the same topic), do you mean maybe
CONFIG_SYS_DCACHE_OFF ? Have you read the thread related to cache
problems on MX51 ? Maybe we have to disable D_CACHE until we find a fix
for the drivers. What do you mean ?
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
More information about the U-Boot
mailing list