[U-Boot] [PATCH v3 5/7] common: add run_command2 for running simple or hush commands

[Jason Hobbs]

On Mon, Jul 25, 2011 at 10:42:18PM +0200, Wolfgang Denk wrote:
> Dear "Jason Hobbs",
> > -# ifndef CONFIG_SYS_HUSH_PARSER -		run_command (p, 0); -#
> > else -		parse_string_outer(p, FLAG_PARSE_SEMICOLON | -
> > FLAG_EXIT_FROM_LOOP); -# endif +	run_command2(p, 0);
> 
> Indentation seems wrong here - it should be one TAB more to the right?

Grr, yes. I will change and resubmit.

> 
> > +int run_command2(const char *cmd, int flag)
> > +{
> > +#ifndef CONFIG_SYS_HUSH_PARSER
> > +	if (run_command(cmd, flag) == -1)
> > +		return 1;
> > +#else
> > +	if (parse_string_outer(cmd,
> > +	    FLAG_PARSE_SEMICOLON | FLAG_EXIT_FROM_LOOP) != 0)
> > +		return 1;
> > +#endif
> > +	return 0;
> > +}
> 
> Can we make this inline [in the normal (non-menu) case], please?

Yes, I will change and resubmit.

Thanks,
Jason