[U-Boot] [PATCH] post: fix up I/O helper usage

Mike Frysinger vapier at gentoo.org
Wed Jul 27 09:41:59 CEST 2011


On Tue, Jul 26, 2011 at 07:43, Wolfgang Denk wrote:
> Mike Frysinger you wrote:
>> The I/O API from Linux defaults to little endian accesses.  In order to
>> do big endian accesses, there are a "be" variants.  The "le32" variants
>> are arch-specific and not terribly common, so change it to the normal
>> Linux API funcs.
>>
>> --- a/include/post.h
>> +++ b/include/post.h
>> @@ -78,12 +78,12 @@
>>
>>  static inline ulong post_word_load (void)
>>  {
>> -     return in_le32((volatile void *)(_POST_WORD_ADDR));
>> +     return inl((volatile void *)(_POST_WORD_ADDR));
>>  }
>
> Is this supposed to fix any real problem, or just a change according
> to your personal preferences?

the "in_le32" funcs (and all the other related "le32" helpers) never
made it into the common Linux API and many
ports (such as the Blackfin arch) never defined them.  so it fixes
building for all the ports which lack "in_le32".  i dont have a source
tree by me atm, but i'd imagine that this is most arches.
-mike


More information about the U-Boot mailing list